Re: [PATCH] New [relation] option engine

Nikolay Shaplov <dhyan@nataraj.su>

From: Nikolay Shaplov <dhyan@nataraj.su>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Yura Sokolov <y.sokolov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Date: 2024-02-07T06:44:52Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Tighten test_predtest's input checks, and improve error messages.

  2. Avoid reference to nonexistent array element in ExecInitAgg().

  3. Clean up newlines following left parentheses

Attachments

В письме от четверг, 1 февраля 2024 г. 09:58:32 MSK пользователь Nikolay 
Shaplov написал:

I' ve updated the patch again, since the output of the 
src/test/modules/test_oat_hooks test have changed.
This test began to register namespace lookups, and since options internals 
have been changed much, number of lookups have been changed too. So I just 
fixed the expected file.

> Hi!
> 
> I've updated the patch, and it should work with modern master branch.
> 
> > 2024-01 Commitfest.
> > 
> > Hi, This patch has a CF status of "Needs Review" [1], but it seems
> > there were CFbot test failures last time it was run [2]. Please have a
> > look and post an updated version if necessary.
> 
> Do we still miss notification facility for CFbot? May be somebody have added
> it since the time I've checked last time?
> 
> > ======
> > [1] https://commitfest.postgresql.org/46/4688/
> > [2] https://cirrus-ci.com/task/5066432363364352
> > 
> > Kind Regards,
> > Peter Smith.


-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su