Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Mark Dilger <mark.dilger@enterprisedb.com>

View thread View on postgr.es
From: Mark Dilger <mark.dilger@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>, Pavel Borisov <pashkin.elfe@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-14T21:18:01Z
Lists: pgsql-bugs, pgsql-hackers 

> On Oct 14, 2021, at 2:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> (a) Isn't that just holding open one connection, not the whole instance?

Yes.

> (b) Wouldn't finish()ing that connection cause the temp tables to be
> dropped, negating the entire point of the test?

The finish() would have to be the last line of the test.

> TBH, I seriously doubt this test case is worth expending buildfarm
> cycles on forevermore.  I'm more than a bit tempted to just drop
> it, rather than also expending developer time figuring out why it's
> not as portable as it looks.

I'm curious if the test is indicating something about the underlying test system.  Only one other test in the tree uses background_psql().  I was hoping Andrew would have something to say about whether this is a bug with that function or just user error on my part.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.