Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org,
Tomas Vondra <tomas.vondra@enterprisedb.com>
Date: 2022-11-19T01:04:40Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On 2022-11-18 15:55:34 -0500, Tom Lane wrote: >> The test_oat_hooks test is failing --- it's not crashing, but >> it's emitting more NOTICE lines than the expected output includes, >> evidently as a result of the hooks getting invoked extra times >> during cache reloads. I can reproduce that here. > Did you already look into where those additional namespace searches are coming > from? There are case in which it is not unproblematic to have repeated > namespace searches due to the potential for races it opens up... I'm not sufficiently interested in that API to dig hard for details, but in a first look it seemed like the extra reports were coming from repeated executions of recomputeNamespacePath, which are forced after a cache invalidation by NamespaceCallback. regards, tom lane
Commits
-
Disable debug_discard_caches in test_oat_hooks test.
- ad0867314daa 15.2 landed
- 3efc82e28951 16.0 landed