Re: src/test/ssl/t/001_ssltests.pl should not tromp on file permissions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-05-16T03:29:23Z
Lists: pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes: > On Tue, May 16, 2017 at 7:05 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> We could maybe make 001_ssltests.pl save and restore the file's >> permissions, but I think probably a cleaner answer is to have it >> make a temporary copy and set the permissions on that. > Ah, you are talking about ss/client.key here... Using a temporary copy > makes the most sense to me, as there is no need to think about putting > back the old permissions on test failure, and the original tree > remains unmodified all the time. Pushed with minor adjustments --- I made the test script unlink the temp file at the end, and tightened the .gitignore patterns a bit. regards, tom lane
Commits
-
In SSL tests, don't scribble on permissions of a repo file.
- ce80240a7d3a 9.5.8 landed
- 91102dab44c3 10.0 landed
- 21c2c3d75e88 9.6.4 landed