Re: Broken HOT chains in system catalogs
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-04-16T17:04:40Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes: > On Sat, Apr 16, 2011 at 11:17:53AM -0400, Tom Lane wrote: >> [ squint... ] Won't that result in the rebuild failing outright? We >> can't remove an index from the pending list till after it's rebuilt, >> for obvious reasons. > That would be a problem if an ambuild function were to call back through the > indexam.c layer to add an individual entry. No core access method does that, > and there's nothing I can see to recommend doing it. Oh ... hm, I was thinking that ambuild calls were also validated using that macro, but now I see they're not even done in this file. So it probably does work to do it like that. It needs rather more than no commentary, though. regards, tom lane