Horton

Re: Weird test mixup

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-14T22:19:38Z
Lists: pgsql-hackers 
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Somehow the 'gin-leave-leaf-split-incomplete' injection point was active 
> in the 'intarray' test. That makes no sense. That injection point is 
> only used by the test in src/test/modules/gin/. Perhaps that ran at the 
> same time as the intarray test? But they run in separate instances, with 
> different data directories.

Do they?  It'd be fairly easy to explain this if these things were
being run in "installcheck" style.  I'm not sure about CI, but from
memory, the buildfarm does use installcheck for some things.

I wonder if it'd be wise to adjust the injection point stuff so that
it's active in only the specific database the injection point was
activated in.

			regards, tom lane

Commits

  1. injection_points: Store runtime conditions in private area

  2. Introduce private data area for injection points

  3. injection_points: Fix incorrect spinlock acquisition

  4. Make GIN tests using injection points concurrent-safe

  5. injection_points: Fix race condition with local injection point tests

  6. injection_points: Introduce runtime conditions

  7. Make GIN test using injection points repeatable

  8. Fix backstop in gin test if injection point is not reached

  9. Try to unbreak injection-fault tests in the buildfarm

  10. Disable tests using injection points in installcheck