Re: pg_upgrade should truncate/remove its logs before running

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Dec 20, 2021 at 09:39:26PM -0600, Justin Pryzby wrote:
>> Are you suggesting to remove these ?
>> -/pg_upgrade_internal.log
>> -/loadable_libraries.txt

> Yep, it looks so as these are part of the logs, the second one being a
> failure state.

>> -/reindex_hash.sql

> But this one is not, no?

I'd like to get to a state where there's just one thing to "rm -rf"
to clean up after any pg_upgrade run.  If we continue to leave the
we-suggest-you-run-these scripts loose in $CWD then we've not really
improved things much.

Perhaps there'd be merit in putting log files into an additional
subdirectory of that output directory, like
pg_upgrade_output.d/logs/foo.log, so that the more-ignorable
output files would be separated from the less-ignorable ones.
Or perhaps that's just gilding the lily.

			regards, tom lane