Horton

Re: TopoSort() fix

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, Rui Hai Jiang <ruihaij@gmail.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-07-29T14:56:05Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Jul 26, 2019 at 08:24:16PM -0400, Tom Lane wrote:
>> I think this is a sufficiently obvious bug, and a sufficiently
>> obvious fix, that we should just fix it and not insist on getting
>> a reproducible test case first.  I think a test case would soon
>> bit-rot anyway, and no longer exercise the problem.
>> I certainly do *not* want to wait so long that we miss the
>> upcoming minor releases.

> +1.  Any volunteers?

If Robert doesn't weigh in pretty soon, I'll take responsibility for it.

			regards, tom lane

Commits

  1. Add an isolation test to exercise parallel-worker deadlock resolution.

  2. Mark advisory-lock functions as parallel restricted, not parallel unsafe.

  3. Fix busted logic for parallel lock grouping in TopoSort().