Re: Bug / shortcoming in has_*_privilege

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Another thing that could raise eyebrows is that I chose to remove the
> "missing_ok" argument from get_role_oid_or_public, so it's not a perfect
> mirror of it.  None of the current callers need it, but perhaps people
> would like these functions to be consistent.

Well, it can't be really consistent anyway: if you did have a missing_ok
argument then you'd need an unusual return convention so you could
distinguish "missing" from "public".  As long as this is a static
function I don't see a strong need for it to mimic the API of the
general get_whatever_oid functions.

			regards, tom lane