Inconsistent error message wording for REINDEX CONCURRENTLY
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Date: 2019-05-02T14:06:42Z
Lists: pgsql-hackers
In view of the REINDEX-on-pg_class kerfuffle that we're currently sorting through, I was very glad to see that the concurrent reindex code doesn't even try: regression=# reindex index concurrently pg_class_oid_index; psql: ERROR: concurrent reindex is not supported for catalog relations regression=# reindex table concurrently pg_class; psql: ERROR: concurrent index creation on system catalog tables is not supported It'd be nice though if those error messages gave the impression of having been written on the same planet. (It might be worth comparing wording of other errors-in-common between what are evidently two completely different code paths...) regards, tom lane
Commits
-
Rework some error strings for REINDEX CONCURRENTLY with system catalogs
- 20e1cc898da6 12.0 landed
-
Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY
- 508300e2e141 12.0 landed
-
Clean up the behavior and API of catalog.c's is-catalog-relation tests.
- 2d7d946cd323 12.0 landed