Re: [patch] libpq one-row-at-a-time API
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marko Kreen <markokr@gmail.com>
Cc: Postgres Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-16T13:33:39Z
Lists: pgsql-hackers
Marko Kreen <markokr@gmail.com> writes: > On Mon, Jul 16, 2012 at 4:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I'm starting to look at this patch now. I think we could drop the >> PQgetRowData() API: it complicates matters for little gain that I can >> see. The argument for it was to avoid the cost of creating a PGresult >> per row, but we're already going to pay the cost of creating a >> PGresult in order to return the PGRES_SINGLE_TUPLE status. > No. Please look again, it is supposed to be called instead of PGgetResult(). Mm. I still think we should drop it, because it's still a dangerous API that's not necessary for the principal benefit of this feature. regards, tom lane