Horton

Re: Let's stop with the retail rebuilds of src/port/ files already

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org
Date: 2018-09-27T14:17:33Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
>> On September 26, 2018 9:03:05 PM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>  # libpgport is needed by some contrib
>>> +# currently we don't install libpgport_shlib.a, maybe we should?

> Likely you should as this could be used directly by out-of-core things.

Maybe, but what things exactly?  Extension modules don't need it, as
they just call the versions built into the core backend.

			regards, tom lane

Commits

  1. Build src/common files as a library with -fPIC.

  2. Remove pqsignal() from libpq's official exports list.

  3. Build src/port files as a library with -fPIC, and use that in libpq.