Re: Mark all GUC variable as PGDLLIMPORT
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
Chapman Flack <chap@anastigmatix.net>,
Julien Rouhaud <rjuju123@gmail.com>,
Michael Paquier <michael@paquier.xyz>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-04-05T14:06:54Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > On 3/30/22 14:37, Robert Haas wrote: >> @RMT: Andres proposed upthread that we should plan to do this just >> after feature freeze. Accordingly I propose to commit at least 0002 >> and perhaps 0001 if people want it just after feature freeze. I >> therefore ask that the RMT either (a) regard this change as not being >> a feature (and thus not subject to the freeze) or (b) give it a 1-day >> extension. The reason for committing it just after freeze is to >> minimize the number of conflicts that it creates for other patches. >> The reason why that's probably an OK thing to do is that applying >> PGDLLIMPORT markings is low-risk. > WFM. I think Tom also has an item he wants to do right at the end of > feature freeze. Yeah, the frontend error message rework in [1]. That has exactly the same constraint that it's likely to break other open patches, so it'd be better to do it after the CF cutoff. I think that doing that concurrently with Robert's thing shouldn't be too risky, because it only affects frontend code while his patch should touch only backend. regards, tom lane [1] https://commitfest.postgresql.org/37/3574/
Commits
-
Remove PGDLLIMPORT marker from __pg_log_level
- 8d3341266508 15.0 landed
-
Mark a few 'bbsink' related functions / variables static.
- b5f44225b833 15.0 landed
-
Add some missing PGDLLIMPORT markings
- 5edeb574285e 15.0 landed
-
Apply PGDLLIMPORT markings broadly.
- 8ec569479fc2 15.0 landed
-
Helper script to apply PGDLLIMPORT markings.
- 80900d469091 15.0 landed
-
Simplify declaring variables exported from libpgcommon and libpgport.
- e04a8059a74c 15.0 cited