Re: pg_dump vs malloc
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-06-10T19:07:00Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > I came across a situation today with a pretty bad crash of pg_dump, > due to not checking the return code from malloc(). When looking > through the code, it seems there are a *lot* of places in pg_dump that > doesn't check the malloc return code. > But we do have a pg_malloc() function in there - but from what I can > tell it's only used very sparsely? > Shouldn't we be using that one more or less everywhere Yup. Have at it. regards, tom lane