Horton

Re: pgindent vs dtrace on macos

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-17T18:20:28Z
Lists: pgsql-hackers 
I went ahead and added SPI.c, Util.c, and the *kwlist_d.h headers
to the exclusion list.  I then tried to run pgindent in a completely
built-out development directory (not distclean'ed, which is the way
I'd always used it before).  This found a few more exclusions we
need to have if we want to allow for that usage.  Pushed the lot.

We still have to deal with

src/backend/utils/sort/qsort_tuple.c
src/pl/plpgsql/src/plerrcodes.h
src/pl/plpython/spiexceptions.h
src/pl/tcl/pltclerrcodes.h

if we want to be entirely clean about this.

			regards, tom lane

Commits

  1. Exclude fmgrprotos.h from pgindent processing.

  2. Fix a few more generator scripts to produce pgindent-clean output.

  3. Further improve pgindent's list of file exclusions.

  4. Improve formatting of create_help.pl and plperl_opmask.pl output.