Horton

Re: FlexLocks

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Cc: "Simon Riggs" <simon@2ndQuadrant.com>, "Alvaro Herrera" <alvherre@commandprompt.com>, "Robert Haas" <robertmhaas@gmail.com>, "Pg Hackers" <pgsql-hackers@postgresql.org>
Date: 2011-11-16T15:41:14Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix copyright notices, other minor editing in new range-types code.

"Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
> Simon Riggs <simon@2ndQuadrant.com> wrote:
>> I just don't see the reason to do a global search and replace on
>> the lwlock name
 
> I was going to review further before commenting on that, but since
> it has now come up -- it seems odd that a source file which uses
> only LW locks needs to change so much for the FlexLock
> implementation.

Yeah, -1 on wideranging source changes for me too.  There is no reason
that the current LWLock API need change.  (I'm not saying that it has
to be same ABI though --- macro wrappers would be fine.)

			regards, tom lane