Horton
Menu

Re: Hot Standy introduced problem with query cancel behavior

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joachim Wieland <joe@mcknight.de>
Cc: Simon Riggs <simon@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Kris Jurka <books@ejurka.com>, Fujii Masao <masao.fujii@gmail.com>
Date: 2010-01-07T15:23:02Z
Lists: pgsql-hackers 
Joachim Wieland <joe@mcknight.de> writes:
> As there were so many boolean SomethingCancelPending variables I changed them
> to be bitmasks and merged all of them into a single variable.

This seems like a truly horrid idea, because those variables are set by
signal handlers.  A bitmask cannot be manipulated atomically, so you
have almost certainly introduced race-condition bugs.

			regards, tom lane