Horton

Re: Inadequate executor locking of indexes

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: David Rowley <david.rowley@2ndquadrant.com>, Julien Rouhaud <rjuju123@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Thomas Munro <thomas.munro@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Rushabh Lathia <rushabh.lathia@gmail.com>
Date: 2019-03-13T01:55:22Z
Lists: pgsql-hackers 
(this is not a reply to your full proposal, just something I thought to
point out)

On 2019/03/13 10:38, David Rowley wrote:
> i.e don't open the indexes for DELETEs.  I had ideas that maybe this
> could be changed to check the idxlockmode and open the indexes if it's
> above AccessSharedLock.  There didn't seem to be a very nice way to
> fetch the RangeTblEntry from the ResultRelInfo though,

Did you miss ri_RangeTableIndex?  It's the range table index of the result
relation for which a given ResultRelInfo is created.

Thanks,
Amit

Commits

  1. Make queries' locking of indexes more consistent.