Horton

Re: PATCH: Make pg_stop_backup() archive wait optional

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Fujii Masao <masao.fujii@gmail.com>
Cc: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Michael Paquier <michael.paquier@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-22T21:34:40Z
Lists: pgsql-hackers 
On 3/22/17 4:42 PM, Peter Eisentraut wrote:
> On 3/22/17 15:14, Stephen Frost wrote:
>>> -SELECT * FROM pg_stop_backup(false);
>>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>>
>>> I think that it's better to get rid of "[" and "]" from the above because
>>> IMO this should be the command example that users actually can run.
>> Using the '[' and ']' are how all of the optional arguments are
>> specified in the documentation, see things like current_setting() in our
>> existing documentation:
>
> In the synopsis, but not in concrete examples.

Wasn't quite sure what the protocol was in this case, and figured it was 
easier to subtract than to add.

-- 
-David
david@pgmasters.net

Commits

  1. Expose waitforarchive option through pg_stop_backup()

  2. Mark pg_start_backup and pg_stop_backup as parallel-restricted.