Horton

Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: michael@paquier.xyz, pavel.stehule@gmail.com, a.zakirov@postgrespro.ru, michael.paquier@gmail.com, pgsql-hackers@postgresql.org
Date: 2018-03-15T04:33:25Z
Lists: pgsql-hackers 
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> Doesn't it make sense if we provide a buildtime-script that
> collects the function names and builds a .h file containing a
> function using the list?

Surely this is a fundamentally misguided approach.  How could it
handle extension GUCs?

			regards, tom lane

Commits

  1. Prevent extensions from creating custom GUCs that are GUC_LIST_QUOTE.

  2. Fix mishandling of quoted-list GUC values in pg_dump and ruleutils.c.