Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2013-01-08T19:35:12Z
Lists: pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2013-01-08 14:25:06 -0500, Tom Lane wrote:
>> This patch seems unnecessary given that we already put a version of Assert()
>> into postgres_fe.h.

> The problem is that some (including existing) pieces of code need to
> include postgres.h itself, those can't easily include postgres_fe.h as
> well without getting into problems with redefinitions.

There is no place, anywhere, that should be including both.  So I don't
see the problem.

			regards, tom lane


Commits

  1. Prevent creation of postmaster's TCP socket during pg_upgrade testing.