Re: sepgsql seems rather thoroughly broken on Fedora 30
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mike Palmiotto <mike.palmiotto@crunchydata.com>
Cc: pgsql-hackers@lists.postgresql.org, Joe Conway <mail@joeconway.com>
Date: 2019-07-25T15:09:04Z
Lists: pgsql-hackers
Mike Palmiotto <mike.palmiotto@crunchydata.com> writes: > On Fri, Jul 19, 2019 at 4:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I can confirm that the 0001 patch fixes things on my Fedora 30 box. >> So that's good, though I don't know enough to evaluate it for style >> or anything like that. > I think the policy is in need of review/rewriting anyway. The proper > thing to do would be to create a common template for all of the > SELinux regtest user domains and create more of a hierarchical policy > to reduce redundancy. If you want to wait for more formal policy > updates, I can do that in my spare time. Otherwise, the patch I posted > should work with the general style of this policy module. Hearing no further comments, I went ahead and pushed 0001 (after checking that it works on F28, which is the oldest Fedora version I have at hand right now). Stylistic improvements to the script are fine, but let's get the bug fixed for now. BTW, I noticed that the documentation about how to run the tests is a bit stale as well --- for instance, it says to use $ sudo semodule -u sepgsql-regtest.pp but that slaps your wrist: The --upgrade option is deprecated. Use --install instead. So if anyone does feel like polishing things in this area, some doc review seems indicated. regards, tom lane
Commits
-
Fix contrib/sepgsql test policy to work with latest SELinux releases.
- 0e259d4bc789 9.4.24 landed
- b22e249837ad 9.5.19 landed
- 0a9ba5baac7d 9.6.15 landed
- 5c3d47287fd7 10.10 landed
- 5a1c61bdf4c0 11.5 landed
- 665329abe7ef 12.0 landed
- f5a4ab23e42a 13.0 landed