Horton

Re: Tests "with" and "alter_table" suffer from name clash

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-30T04:50:32Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@gmail.com> writes:
> In fact only REL_10_STABLE had the problem, because commit 2cf8c7aa
> already fixed the other instance in later branches.  I'd entirely
> forgotten that earlier discussion, which apparently didn't quite go
> far enough.   So I only needed to push the with.sql change.  Done.

Hah, I thought this felt familiar.  So the real problem is that
my backpatch (b15a8c963) only fixed half of the hazard.  Sigh.

			regards, tom lane

Commits

  1. Fix overly generic name in with.sql test.

  2. Clean up duplicate table and function names in regression tests.