Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2018-04-28T18:05:15Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> JIT is introducing the installation of LLVM bitcode modules, and any
> installation done results in the following comment in output, which
> repeats basically for all the extensions installed:
> # Then install files
> #
> # The many INSTALL_DATA invocations aren't particularly fast, it'd be
> # good if we could coalesce them, but I didn't find a good way.

> Andres, could it be possible to move at least that block of comments in
> a place where this is not user-visible?

Agreed, there shouldn't be comments in the emitted shell commands;
I'm a bit surprised that works at all.  Close inspection of the
"make install" output revealed a few other issues, which I hope
I fixed rather than making things worse.

			regards, tom lane


Commits

  1. Un-break contrib install with llvm.

  2. Minor cleanups for install_llvm_module/uninstall_llvm_module Make macros.