Horton

Re: narwhal and PGDLLIMPORT

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marco Atzeri <marco.atzeri@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org
Date: 2014-02-11T17:15:26Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

Marco Atzeri <marco.atzeri@gmail.com> writes:
> On 09/02/2014 14:10, Andrew Dunstan wrote:
>> On 02/09/2014 01:12 AM, Marco Atzeri wrote:
>>> we should have get rid of dlltool on cygwin.
>>> At least it is not used on my build

>> The send in a patch. The patch you sent in previously did not totally
>> remove it IIRC.

> attached patch versus latest git.

I've committed this with some fixes.  However, I omitted the hunks that
change the names of generated shared libraries (to add SO_MAJOR_VERSION).
I think that requires some policy discussion around whether we want to
do it or not, and in any case it's unrelated to the issues being discussed
in this thread.  If you still want that, please submit it as a separate
patch in a new thread, with some discussion as to why it's a good idea.

			regards, tom lane