Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Alex Hunsaker <badalex@gmail.com>

Cc: Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-01-06T21:05:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix breakage from earlier plperl fix.
- bd0e74a9ce98 9.2.0 cited

Alex Hunsaker <badalex@gmail.com> writes:
> Oh my... I dunno exactly what I was smoking last night, but its a good
> thing I didn't share :-). Uh so my test program was also completely
> wrong, Ill have to redo it all. I've narrowed it down to:
>         if ((type == SVt_PVGV || SvREADONLY(sv)))
>         {
>             if (type != SVt_PV &&
>                 type != SVt_NV)
>             {
>                 sv = newSVsv(sv);
>             }
>        }

Has anyone tried looking at the source code for SvPVutf8 to see exactly
what cases it fails on?  The fact that there's an explicit croak() call
makes me think it might not be terribly hard to tell.

			regards, tom lane