Horton
Menu

Re: Fix pg_upgrade to preserve datdba

Jan Wieck <jan@wi3ck.info>

View thread
From: Jan Wieck <jan@wi3ck.info>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Robins Tharakan <tharakan@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-03-21T17:15:54Z
Lists: pgsql-hackers 
On 3/21/21 12:57 PM, Tom Lane wrote:
> Jan Wieck <jan@wi3ck.info> writes:
>> On 3/20/21 12:39 AM, Jan Wieck wrote:
>>> On the way pg_upgrade also mangles the pg_database.datdba
>>> (all databases are owned by postgres after an upgrade; will submit a
>>> separate patch for that as I consider that a bug by itself).
> 
>> Patch attached.
> 
> Hmm, doesn't this lose all *other* database-level properties?
> 
> I think maybe what we have here is a bug in pg_restore, its
> --create switch ought to be trying to update the database's
> ownership.

Possibly. I didn't look into that route.


Regards, Jan

-- 
Jan Wieck
Principle Database Engineer
Amazon Web Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Count individual SQL commands in pg_restore's --transaction-size mode.

  2. Reduce number of commands dumpTableSchema emits for binary upgrade.

  3. Invent --transaction-size option for pg_restore.

  4. Rearrange pg_dump's handling of large objects for better efficiency.

  5. Add temporal PRIMARY KEY and UNIQUE constraints

  6. Fix typo and case in messages