Re: Add explicit casts in four places to simplehash.h

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Geier <geidav.pg@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-04T13:25:42Z
Lists: pgsql-hackers
David Geier <geidav.pg@gmail.com> writes:
> On 11/3/22 15:50, Tom Lane wrote:
>> The bigger picture here is that we do actually endeavor to keep
>> (most of) our headers C++ clean, but our tool cpluspluscheck misses
>> these problems because it doesn't try to use these macros.
>> I wonder whether there is a way to do better.

> What about having a custom header alongside cpluspluscheck which 
> references all macros we care about?

Can't see that that would help, because of the hand maintenance
required to make it useful.

			regards, tom lane



Commits

  1. Add casts to simplehash.h to silence C++ warnings.