Re: Add explicit casts in four places to simplehash.h
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Geier <geidav.pg@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-04T13:25:42Z
Lists: pgsql-hackers
David Geier <geidav.pg@gmail.com> writes: > On 11/3/22 15:50, Tom Lane wrote: >> The bigger picture here is that we do actually endeavor to keep >> (most of) our headers C++ clean, but our tool cpluspluscheck misses >> these problems because it doesn't try to use these macros. >> I wonder whether there is a way to do better. > What about having a custom header alongside cpluspluscheck which > references all macros we care about? Can't see that that would help, because of the hand maintenance required to make it useful. regards, tom lane
Commits
-
Add casts to simplehash.h to silence C++ warnings.
- eeb5461e76ae 14.6 landed
- cf8b7d374ae1 16.0 landed
- 725cd4d2e481 15.1 landed
- 50467082c9d4 13.9 landed