Horton

Re: pgsql: Add 'basebackup_to_shell' contrib module.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Magnus Hagander <magnus@hagander.net>
Date: 2022-03-30T16:34:34Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> Because I forgot about cfbot when attaching the patch, cfbot actually ran with
> it under this thread's cf entry.  It does look like an improvement to me:
> https://cirrus-ci.com/task/6397292629458944?logs=test_world#L900
> We certainly can do better, but it's sufficiently better than what we have
> right now. So I'd like to commit it?

No objection here.

>> Would we want to do this in all branches? I'd vote for yes, but ...

> Unless somebody speaks in favor of doing this across branches, I'd just go for
> HEAD.

+1 for HEAD only, especially if we think we might change it some more
later.  It seems possible this might break somebody's tooling if we
drop it into minor releases.

One refinement that comes to mind as I look at the patch is to distinguish
between "check" and "installcheck".  Not sure that's worthwhile, but not
sure it isn't, either.

			regards, tom lane

Commits

  1. Print information about type of test and subdirectory before running tests.

  2. In basebackup_to_shell tests, properly set up pg_hba.conf.

  3. Add .gitignore for basebackup_to_shell.

  4. basebackup_to_shell: Add TAP test.

  5. Document basebackup_to_shell.required_role.

  6. Add 'basebackup_to_shell' contrib module.