Horton

Re: PG 12 draft release notes

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-05-21T00:48:15Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: PG 12 relnotes: update wording on truncate/vacuum item

  2. docs: PG 12 relnotes, update btree items

  3. doc: PG 12 relnotes, list added snowball/FTS languages

  4. doc: PG 12 relnotes, merge new SQL partition function items

  5. docs: PG 12 release notes, support functions

  6. docs: PG 12 relnote adjustments based on feedback from Tom Lane

  7. docs: adjust RECORD PG 12 relnote item

  8. doc: adjust PG 12 relnotes item on float digit adjustment

  9. doc: adjustments for PG 12 release notes

  10. docs: fix duplicate wording in PG 12 release notes

  11. doc: properly attibute PG 12 pgbench release note item

  12. doc: PG 12 release notes: normalize attribution names

  13. Refactor the fsync queue for wider use.

  14. Add "split after new tuple" nbtree optimization.

  15. Add nbtree high key "continuescan" optimization.

  16. Allow amcheck to re-find tuples using new search.

  17. Consider secondary factors during nbtree splits.

  18. Partial implementation of SQL/JSON path language

  19. Allow extensions to generate lossy index conditions.

  20. Make TupleTableSlots extensible, finish split of existing slot type.

  21. Reduce path length for locking leaf B-tree pages during insertion

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-20 18:56:50 -0400, Tom Lane wrote:
>> I'm not sure which of my commits you want me to opine on, other than

> That was one of the main ones. I'm also specifically wondering about:

>> Author: Tom Lane <tgl@sss.pgh.pa.us>
>> 2019-02-09 [1fb57af92] Create the infrastructure for planner support functions.
>> <para>
>> Add support for <link linkend="sql-createfunction">function
>> selectivity</link> (Tom Lane)
>> </para>
>> </listitem>
>> 
>> Hm, that message doesn't seem like an accurate description of that
>> commit (if anything it's a391ff3c?). Given that it all requires C
>> hackery, perhaps we ought to move it to the source code section?

Yes, this should be in "source code".  I think it should be merged
with a391ff3c and 74dfe58a into something like

	Allow extensions to create planner support functions that
	can provide function-specific selectivity, cost, and
        row-count estimates that can depend on the function arguments.
        Support functions can also transform WHERE clauses involving
        an extension's functions and operators into indexable clauses
        in ways that the core code cannot for lack of detailed semantic
	knowledge of those functions/operators.

> and perhaps you could opine on whether we ought to include

>> <listitem>
>> <!--
>> Author: Tom Lane <tgl@sss.pgh.pa.us>
>> 2019-02-11 [1d92a0c9f] Redesign the partition dependency mechanism.
>> -->
>> 
>> <para>
>> Improve handling of partition dependency (Tom Lane)
>> </para>
>> 
>> <para>
>> This prevents the creation of inconsistent partition hierarchies
>> in rare cases.
>> </para>
>> </listitem>

It's probably worth mentioning, but I'd say something like

        Fix bugs that could cause ALTER TABLE DETACH PARTITION
        to not drop objects that should be dropped, such as
        automatically-created child indexes.

The rest of it is not terribly interesting from a user's standpoint,
I think.

> And lastly, opine on the int GUC fractions, microsoecond, and cost_delay
> items?

I agree with your comments on those.

			regards, tom lane