Horton
Menu

Re: Optimizing GetConflictingVirtualXIDs()

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Greg Stark <gsstark@mit.edu>, pgsql-hackers@postgresql.org
Date: 2010-02-14T17:45:50Z
Lists: pgsql-hackers 
Simon Riggs <simon@2ndQuadrant.com> writes:
> On Sun, 2010-02-14 at 17:06 +0000, Greg Stark wrote:
>> EINSUFFICIENTEXPLANATION :)

> ...I like that error code.

I think more EINSUFFICIENTCOMMENTS.  The patch should also add a comment
to the function, along the lines of "While we have the lock, also update
RecentGlobalXmin, so that we will have as up-to-date a value as possible
for next time".  You've also failed to document the meaning or purpose
of the added output parameter.

			regards, tom lane