Re: Unimpressed with pg_attribute_always_inline
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>,
Thomas Munro <thomas.munro@enterprisedb.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-09T00:56:47Z
Lists: pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes: > Anyway, ISTM that it should be possible to make > pg_attribute_always_inline have no effect in typical debug builds. > Wouldn't that make everyone happy? That would improve matters, but do we have access to the -O switch level as an #if condition? The use-case I'm generally worried about involves recompiling individual files at -O0, with something like make PROFILE=-O0 nodeHashjoin.o so trying to, say, get configure to adjust the macro isn't really going to help. The other half of the problem is the warnings, but I think Thomas' patch would alleviate that. regards, tom lane
Commits
-
Improve implementation of pg_attribute_always_inline.
- 434e6e148441 11.0 landed
-
Add pg_attribute_always_inline.
- dbb3d6f0102e 11.0 cited