Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start.

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-05-20T00:49:00Z
Lists: pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> Do you think that it would be better to list the letter list for each
> keyword in repl_scanner.l or have something more generic? As not that
> many commands are added in the replication protocol, I would think
> that this is more than enough for each command, say:
> [Ss][Ll][Oo][Tt]                { return K_SLOT; }
> etc.

Yeah, that's probably good enough.  It might be worth the trouble to
make out-of-line definitions, as in cubescan.l's handling of NaN and
Infinity for instance, but that's just cosmetic.

			regards, tom lane


Commits

  1. Rethink flex flags for syncrep_scanner.l.

  2. Capitalize SHOW when testing whether target_session_attrs=read-write.