Horton

Re: Getting rid of regression test input/ and output/ files

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-12-19T22:48:02Z
Lists: pgsql-hackers 
Corey Huinker <corey.huinker@gmail.com> writes:
> I have a nitpick about the \getenv FOO FOO lines.
> It's a new function to everyone, and to anyone who hasn't seen the
> documentation it won't be immediately obvious which one is the ENV var and
> which one is the local var. Lowercasing the local var would be a way to
> reinforce which is which to the reader. It would also be consistent with
> var naming in the rest of the script.

Reasonable idea.  Another thing I was wondering about was whether
to attach PG_ prefixes to the environment variable names, since
those are in a more-or-less global namespace.  If we do that,
then a different method for distinguishing the psql variables
is to not prefix them.

			regards, tom lane

Commits

  1. Merge dblink's paths test script into its main test.

  2. Remove dynamic translation of regression test scripts, step 2.

  3. Remove dynamic translation of regression test scripts, step 1.

  4. Add a \getenv command to psql.