Horton
Menu

Re: Allow placeholders in ALTER ROLE w/o superuser

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, nathandbossart@gmail.com, steve@supabase.io, pgsql-hackers@postgresql.org
Date: 2022-11-18T21:33:19Z
Lists: pgsql-hackers 
Alexander Korotkov <aekorotkov@gmail.com> writes:
> This makes sense.  But do we really need to store the OID of the role?
>  validate_option_array_item() already checks if the placeholder option
> passes validation for PGC_SUSET.  So, we can just save a flag
> indicating that this check was not successful.  If so, then the value
> stored can be only used for PGC_USERSET.  Do you think this would be
> correct?

Meh ... doesn't seem like much of an improvement.  You still need
to store something that's not there now.  This also seems to require
some shaky assumptions about decisions having been made when storing
still being valid later on.  Given the possibility of granting or
revoking permissions for SET, I think we don't really want it to act
that way.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove extra regress check arguments from test_pg_db_role_setting

  2. meson: Add 'running' test setup, as a replacement for installcheck

  3. Add USER SET parameter values for pg_db_role_setting

  4. Fix sloppy cleanup of roles in privileges.sql.

  5. Drop test user when done with it.

  6. GRANT rights to CURRENT_USER instead of adding roles

  7. Clean up roles from roleattributes test

  8. Make repeated 'make installcheck' runs work