Re: MacPorts support for "extra" tests

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-21T03:39:38Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> Peter E added some nice tests for LDAP and Kerberos, but they assume
> you have Homebrew when testing on a Mac.  Here's a patch to make them
> work with MacPorts too (a competing open source port/package
> distribution that happens to be the one that I use).  The third
> "extra" test is ssl, but that was already working.

+1, but could we comment that a bit?  I'm thinking of something like

  # typical library location for Homebrew

in each of the if-branches.

			regards, tom lane


Commits

  1. Add MacPorts support to src/test/ldap tests.