Re: Dead code in ps_status.c
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-16T14:38:18Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes: > On Thu, Feb 16, 2023 at 6:34 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Hm, is "defined(sun)" true on any live systems at all? > My GCC compile farm account seems to have expired, or something, so I > couldn't check on wrasse's host (though whether wrasse is "live" is > debatable: Solaris 11.3 has reached EOL, it's just that the CPU is too > old to be upgraded, so it's not testing a real OS that anyone would > actually run PostgreSQL on). But from some googling[1], I think > __sun, __sun__ and sun should all be defined. My account still works, and what I see on wrasse's host is tgl@gcc-solaris11:~$ gcc -x c /dev/null -dM -E | grep -i svr #define __SVR4 1 #define __svr4__ 1 tgl@gcc-solaris11:~$ gcc -x c /dev/null -dM -E | grep -i sun #define __sun 1 #define sun 1 #define __sun__ 1 I don't know a way to get the list of predefined macros out of the compiler wrasse is actually using (/opt/developerstudio12.6/bin/cc), but doing some experiments with #ifdef confirmed that it defines __sun, __sun__, and __svr4__, but not __svr5__. regards, tom lane
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Define PS_USE_CLOBBER_ARGV on GNU/Hurd.
- 29a3e22f3568 14.21 landed
- 3995e4a9d8c6 15.16 landed
- 32b236644d33 19 (unreleased) landed
- bcfca332f100 18.2 landed
- d66a922f9247 17.8 landed
- a1407daded69 16.12 landed
-
Remove obsolete platforms from ps_status.c.
- d2ea2d310dfd 16.0 landed