Horton

Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, David Fetter <david@fetter.org>, pgsql-hackers@postgresql.org
Date: 2018-10-25T11:52:01Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> To keep the code simple, you could do something like that, by checking
> the head keywords for a match with CREATE TRIGGER, and then move all the
> existing conditions within it:
> ...
>     char *execute_keyword;
> ...
>         blah and use execute_keyword in the lists;

Don't think that works unless we remove some of the "const" annotation
in COMPLETE_WITH; which I'd rather not.

			regards, tom lane

Commits

  1. Add tab completion of EXECUTE FUNCTION for CREATE TRIGGER in psql

  2. Improve tab completion of CREATE EVENT TRIGGER in psql

  3. Improve tab completion for ANALYZE, EXPLAIN, and VACUUM.