Re: pgsql: Refactor dlopen() support

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2018-09-07T21:13:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Work around stdbool problem in dfmgr.c.
- ff47d4bf1f20 12.0 landed
Refactor dlopen() support
- 842cb9fa62fc 12.0 cited

Attachments

undo-stdbool-damage-in-dfmgr.patch (text/x-diff) patch

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 07/09/2018 16:19, Tom Lane wrote:
>> Somehow or other, the changes you made in dfmgr.c's #include lines
>> have made it so that find_rendezvous_variable's local "bool found"
>> variable is actually of type _Bool (which is word-wide on these
>> machines).

> Ah because dlfcn.h includes stdbool.h.  Hmm.

Yeah, and that's still true as of current macOS, it seems.

I can make the problem go away with the attached patch (borrowed from
similar code in plperl.h).  It's kind of grotty but I'm not sure there's
a better way.

			regards, tom lane