Horton

Re: Race-like failure in recovery/t/009_twophase.pl

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2017-07-02T17:55:29Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> * Some effort should be put into emitting text to the log showing
>> what's going on, eg print("Now london is master."); as appropriate.

> Check.  Not "print" though; I think using note(" .. ") (from Test::More)
> is more appropriate.

Will do, thanks for the suggestion.

			regards, tom lane

Commits

  1. Fix race condition in recovery/t/009_twophase.pl test.

  2. Fix bug in PostgresNode::query_hash's split() call.

  3. Try to improve readability of recovery/t/009_twophase.pl test.