Re: [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Stark <stark@postgresql.org>, Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2010-02-23T16:13:06Z
Lists: pgsql-hackers
I wrote:
> BTW, I notice that after allegedly fixing things, we are now seeing
> fsync failures during CREATE DATABASE in the installcheck phase of
> buildfarm runs on (apparently) all the Windows critters, plus a
> couple of other platforms too.  This mystifies me.  I could believe
> that there was something still wrong with copydir.c, but then how
> come these machines are getting through the earlier "make check"
> phase?

BTW, although things seem to be going green with the RDONLY->RDWR
change, I'm still mystified why these machines didn't fail at
"make check".  Is it possible that "make check" runs the postmaster
with fsync disabled?  I don't see that in the code anywhere...

			regards, tom lane