Re: statement_timeout is not working as expected with postgres_fdw

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-16T16:45:39Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> Concretely, I think we should replace the abort_cleanup_incomplete
> flag from my previous patch with a changing_xact_state flag and set
> that flag around all transaction state changes, clearing it when such
> changes have succeeded.  On error, the flag remains set, so we know
> that the state of that connection is unknown and that we must close it
> (killing outer transaction levels as needed).

> Thoughts?

Sounds plausible.

			regards, tom lane


Commits

  1. postgres_fdw: Allow cancellation of transaction control commands.

  2. Allow queries submitted by postgres_fdw to be canceled.

  3. Fix multiple problems in postgres_fdw query cancellation logic.