Horton
Menu

Re: knngist patch support

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Hitoshi Harada <umi.tanuki@gmail.com>, Teodor Sigaev <teodor@sigaev.ru>, Oleg Bartunov <oleg@sai.msu.su>, tomas@tuxteam.de, "Ragi Y. Burhum" <rburhum@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2010-02-14T17:24:59Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> OK.  In that case, any objections to my applying the attached patch,
> which I believe implements this as you suggested?

Um, did you test this version?  It looks like the macros are still
defined according to the idea that SearchSysCache takes five arguments.

Also, I'd suggest adding explicit comments to syscache.h suggesting
that SearchSysCache etc are meant to be called via the macros
rather than directly.

I didn't check all the individual calls, but it looks generally
sane except for those points.

			regards, tom lane