Re: Timing-sensitive case in src/test/recovery TAP tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-09T13:39:04Z
Lists: pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes: > On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Michael Paquier <michael.paquier@gmail.com> writes: >>> I got the same thought, wondering as well if get_slot_xmins should be >>> renamed check_slot_xmins with the is() tests moved inside it as well. >>> Not sure if that's worth the API ugliness though. >> Mmm, doesn't seem like that's worth doing, but I'm half tempted to merge >> wait_slot_xmins into get_slot_xmins so you can't skip it ... > Let's do that please. Merging both was my first feeling when > refactoring this test upthread. Should I send a patch? Sure, have at it. regards, tom lane
Commits
-
Simplify fetch-slot-xmins logic in recovery TAP tests.
- 3043c1ddd13c 10.0 landed
-
Fix yet another race condition in recovery/t/001_stream_rep.pl.
- 4576a69354fa 10.0 landed
-
Improve wait logic in TAP tests for streaming replication.
- 5c77690f6f41 10.0 landed