Re: Detection of IPC::Run presence in SSL TAP tests
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2017-06-15T19:57:44Z
Lists: pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes: > On Tue, Jun 13, 2017 at 11:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I'd vote for removing this and adding a configure-time check that >> insists on IPC::Run when --enable-tap-tests is given. > There was a patch last year to do something like that: > https://www.postgresql.org/message-id/56BDDC20.9020506@postgrespro.ru > While Test::More is part of any standard installation, IPC::Run is > not. FWIW, I still think that this is worth checking for. That's way > better than having the TAP tests explode with a weird fatal failure > where one needs to dig into the logs just to find out that the module > is missing. > Attached is an updated patch, with credit mainly going to Eugene > Kazakov. I have run autoconf myself, I know that usually committers do > that... Hope you don't mind. Pushed, thanks. I grabbed the very latest copy of ax_prog_perl_modules out of the GNU archives --- it's only cosmetically different, but we might as well be au courant. regards, tom lane
Commits
-
Make configure check for IPC::Run when --enable-tap-tests is specified.
- c254970ad609 10.0 landed