Horton

Re: [HACKERS] Useless code in ExecInitModifyTable

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Stephen Frost <sfrost@snowman.net>, pgsql-hackers@postgresql.org
Date: 2018-01-17T19:46:00Z
Lists: pgsql-hackers 
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> writes:
> (2018/01/15 11:35), Amit Langote wrote:
>> On 2018/01/15 11:28, Stephen Frost wrote:
>>> Seems like this has gotten a review (and quite a bit of down-stream
>>> discussion that seemed pretty positive), and the latest patch still
>>> applies cleanly and passes the regression tests- is there some reason
>>> it's still marked as Needs Review?  Seems like it should really be in
>>> Ready for Committer state.
>>> Amit, if you agree, would you mind going ahead and changing it?

>> Sure, done.

> Thanks for reviewing, Amit!

Pushed.  I think the long delay on this is really my fault for having
raised an incorrect objection initially --- apologies for that.

			regards, tom lane

Commits

  1. Remove useless lookup of root partitioned rel in ExecInitModifyTable().

  2. Don't scan partitioned tables.