Horton

Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, clemens@ladisch.de, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-06-12T05:40:24Z
Lists: pgsql-bugs 
> On 12 Jun 2019, at 04:36, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Tue, Jun 11, 2019 at 09:32:55AM -0400, Alvaro Herrera wrote:
>> Yeah, looks better.  I think the error message should be a normal elog()
>> cache failure, though ... at least in the COMMENT case, the obj-does-not-
>> exist message is supposed to be thrown by get_object_address(), before
>> check_object_ownership is called.
>> 
>> As a matter of style, I would get rid of the 'conoid' variable and just
>> use address.objectId where needed.
> 
> OK.  I have included both your comments, and committed the patch down
> to 9.5 where it applies.  Thanks for the feedback!

Thanks!

> s/unathorized/unauthorized/ by the way.

Ugh, sorry about that.

cheers ./daniel

Commits

  1. Fix handling of COMMENT for domain constraints