Re: pgindent vs variable declaration across multiple lines
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
pgsql-hackers@postgresql.org
Date: 2023-01-24T15:33:35Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > On 2023-01-22 Su 17:34, Tom Lane wrote: >> I've also attached a diff >> representing the delta between what current pg_bsd_indent wants to do >> to HEAD and what this would do. All the changes it wants to make look >> good, although I can't say whether there are other places it's failing >> to change that we'd like it to. > Changes look good. There are a handful of places where I think the code > would be slightly more readable if a leading typecast were moved to the > second line. Possibly, but that's the sort of decision that pgindent leaves to human judgment I think. It'll reflow comment blocks across lines, but I don't recall having seen it move line breaks within code. regards, tom lane
Commits
-
Improve indentation of multiline initialization expressions.
- 064750af4f4e 16.0 landed