Re: pgbench - add \if support

Teodor Sigaev <teodor@sigaev.ru>

From: Teodor Sigaev <teodor@sigaev.ru>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-03-22T14:44:21Z
Lists: pgsql-hackers
Thank you, pushed

Fabien COELHO wrote:
> 
> Hello Teodor,
> 
>> Patch seems usefull and commitable except comments in conditional.[ch]. I'd 
>> like to top/header comment in each file more detailed and descriptive. As for 
>> now it mentions only psql usage without explaining how it is basic or common.
> 
> Indeed, it was not updated.
> 
> I've fixed the file names and added a simple description at the beginning of the 
> header file, and a one liner in the code file.
> 
> Do you think that more is needed?
> 
> The patch also needed a rebase after the hash function addition.
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/


Commits

  1. Add \if support to pgbench