Re: includeifexists in configuration file

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira de Oliveira <euler@timbira.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-11-16T14:54:18Z
Lists: pgsql-hackers
Euler Taveira de Oliveira <euler@timbira.com> writes:
> On 16-11-2011 02:28, Greg Smith wrote:
>> By recent popular request in the ongoing discussion saga around merging the
>> recovery.conf, I've added an "includeifexists" directive to the
>> postgresql.conf in the attached patch.

> I'm not following the merging recovery.conf thread but isn't it worth emitting
> at least an WARNING message when the file does not exist?

> Something like

> WARNING:  could not open configuration file "/foo/missing.conf", skipping

Minor note here: people keep thinking that WARNING > LOG with respect to
messages that can only go to the server log.  This is not correct ...
LOG would be the right elevel to use.

			regards, tom lane